fix(reconciler): bound the Flight EOF wait by the render deadline (#204 follow-up) - #214
Merged
Conversation
🦋 Changeset detectedLatest commit: bde9ee8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the unresolved P1 Codex finding on #204 (
reconciler.ts:368): when the decoded root had no pending boundaries but the Flight source stayed open, the unconditionalDeferred.await(flightDone)bypassedmaxElapsedMs, so a stalled transport hungstream()anddispatch()forever.The EOF wait is now raced against the render deadline via the same helper the pending-boundary path uses (
waitOrDeadline, generalized fromwaitPendingOrDeadline), failing withelapsed-time-exceededand tearing down the Flight source (reader cancel) on timeout. Unbounded behavior with no configured budget is unchanged and identical to the pending path.Tests
bounds Flight EOF for stream and dispatch and cancels the source— never-closing Flight source +maxElapsedMs: 150, assertselapsed-time-exceededwithin budget and exactly onecancel()for bothstreamanddispatch.Gates: scoped rstest,
pnpm typecheck,pnpm lint— all green.